Added CHANGELOG entry for PromQL engine optimizations #3991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
reviewed
Mar 22, 2021
CHANGELOG.md
Outdated
| @@ -16,6 +16,7 @@ | |||
| * `cortex_ruler_clients` | |||
| * `cortex_ruler_client_request_duration_seconds` | |||
| * [ENHANCEMENT] Query-frontend/scheduler: added querier forget delay (`-query-frontend.querier-forget-delay` and `-query-scheduler.querier-forget-delay`) to mitigate the blast radius in the event queriers crash because of a repeatedly sent "query of death" when shuffle-sharding is enabled. #3901 | |||
| * [ENHANCEMENT] Querier / ruler: optimized PromQL query engine. #3934 #3989 | |||
There was a problem hiding this comment.
Maybe "some optimizations to PromQL query engine"?
It would be better if #3934 listed what those were.
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
add-changelog-entry-for-promql-optimization
branch
from
4bf78cf to
16d015b
Compare
pstibrany
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Following up the comment #3989 (comment) by @bboreham, in this PR I'm adding a CHANGELOG entry to group PromQL engine optimizations. Not sure if we should be more specific or a generic message is enough.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]