Update Prometheus vendoring #3934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Things needed to be updated to accomodate this change in interface: prometheus/prometheus#8489 Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
|
Would you mind updating Prometheus in this PR to latest master to get fix for prometheus/prometheus#8558? |
|
@pstibrany Done |
gouthamve
force-pushed
the
update-prom-vendor
branch
from
8bf73d3 to
75fbd0e
Compare
To pull in prometheus/prometheus#8558 Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve
force-pushed
the
update-prom-vendor
branch
from
75fbd0e to
c5cdbe7
Compare
pstibrany
approved these changes
Mar 15, 2021
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve
force-pushed
the
update-prom-vendor
branch
from
4b3ff23 to
bb3041b
Compare
pracucci
reviewed
Mar 15, 2021
There was a problem hiding this comment.
Thanks @gouthamve for working on this! LGTM modulo a comment about the ingester push. Also a couple of things:
- Could you upgrade Prometheus again? I got a couple of PRs merged which I would love to see backported to Cortex.
- PromQL engine added
EnableNegativeOffset. Should we add a config option for that, similarly to what we did forEnableAtModifier?
Was removed in error Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
|
Updated Prometheus. Will add option for |
OOh, Prometheus is exciting again :D Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve
force-pushed
the
update-prom-vendor
branch
from
fb621f2 to
b460aa3
Compare
This was referenced Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things needed to be updated to accomodate this change in interface:
prometheus/prometheus#8489
Signed-off-by: Goutham Veeramachaneni gouthamve@gmail.com