Fixed TestSchedulerEnqueueWithFrontendDisconnect flakyness #3434
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The test
TestSchedulerEnqueueWithFrontendDisconnect
is flaky (CI failed here). The reason is that there's no guarantee that the query-frontend disconnected from the scheduler and its request canceled beforeverifyQuerierDoesntReceiveRequest
is called. The change done in this test should help to reduce this likelihood.I also took the opportunity to:
cortex_query_scheduler_connected_workers
tocortex_query_scheduler_connected_querier_clients
, because:_clients
, so I've renamed for consistencycortex_query_scheduler_connected_frontend_clients
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]