Add integration test on query-scheduler #3429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
force-pushed
the
add-integration-test-on-query-scheduler
branch
from
c570aac to
c5696fb
Compare
pracucci
commented
Oct 30, 2020
| @@ -83,8 +83,8 @@ func NewQuerierSchedulerWorkers(cfg QuerierWorkersConfig, handler RequestHandler | |||
| } | |||
|
|
|||
| frontendClientsGauge := promauto.With(reg).NewGauge(prometheus.GaugeOpts{ | |||
| Name: "cortex_query_scheduler_worker_frontend_clients", | |||
| Help: "The current number of frontend clients.", | |||
| Name: "cortex_querier_query_frontend_clients", | |||
There was a problem hiding this comment.
I would prefer it cortex_query_scheduler metrics prefix are reserved for the scheduler. Thoughts?
There was a problem hiding this comment.
👍 Good idea, thanks for spotting.
|
Flaky test should be fixed by this PR: #3434 |
pstibrany
approved these changes
Nov 2, 2020
pracucci
force-pushed
the
add-integration-test-on-query-scheduler
branch
from
c5696fb to
2109545
Compare
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
add-integration-test-on-query-scheduler
branch
from
3b77630 to
fdbde79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In this PR I've added integration tests for the query-scheduler. The diff will be easier to review if you enable "hide whitespace changes".
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]