Skip to content

OpenGL ES #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: development
Choose a base branch
from
Draft

OpenGL ES #40

wants to merge 3 commits into from

Conversation

janisozaur
Copy link
Contributor

This is #37 with actual gles commit on top for discussion.

The code was tested on several machines and in some cases there were issues with rendering text. The platforms affected were laptop nvidia and rpi5/vc7 and the issue observed was exactly the same. While nvidia was easily addressed by adding highp, the same issue on rpi5 persists. Interestingly, on another ARM-based device with RK3588 and Mali GPU this was not observed. I suspect this might be rpi quirk and will see if I manage to debug this in any way.

Any help appreciated. I attach screenshots of the issue.
cc_gles_4x
cc_gles_1x

@Causeless
Copy link
Contributor

I'm not sure this is specifically a text rendering issue. As far as I know, text in CC is just using a spritesheet and treated no differently to any other graphics in the game. It's relatively complete, with kerning implemented, but the actual font rendering is nothing beyond a blit- there's no vector representation of the text characters.

I suspect that if there's an issue here, it's actually some sort of filtering or interpolation applied over the entire screen, and it's just most obvious with text.

@Causeless Causeless requested a review from HeliumAnt January 24, 2024 21:28
@Causeless
Copy link
Contributor

If you look at the left side of the picture, there looks to be a lot of stray white pixels that I don't recall seeing before. Almost as if the text pixels were placed in the wrong place.

@HeliumAnt
Copy link
Contributor

Looks like the palette is definitely getting corrupted but probably everything else that's uploaded as well, considering how that text looks

@janisozaur
Copy link
Contributor Author

If it was the palette, wouldn't just the colors be shifted? The way it works now is there are vertical stripes (not really, but it looks like this when the text expands) on the screen that are somehow filtered from getting proper rendering.

@HeliumAnt
Copy link
Contributor

ok not the palette, that would have to create waaay more grey spots, since the greyed out colors on the background occur in a lot more places. Also this has to happen somewhere in software drawing, since otherwise I'd expect more issues on non text elements and more general artifacts, especially any artifacts on the scrolling background. Looks like it may just be things drawn by the putpixel methods (scene color)?
(or the assets are already corrupted, which seems unlikely since the letters all fail differently).

@Causeless
Copy link
Contributor

Hey, I can't really merge this up-to-date as I don't know what I'm doing, but there was some fixes in dev where some pallete indices were messed up.

@janisozaur can you try merging uip to dev and seeing if this is still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants