-
Notifications
You must be signed in to change notification settings - Fork 19
GL updates #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GL updates #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple comments, but I don't know much about shader programming so feel free to swat em away 🫡
9c0acdf
to
6024e4b
Compare
I addressed the comments. Yes, this is for GLES support, already implemented: d137251 (development...gles-v2) I'd like to implement it either as runtime switch or as a compile time one. I prefer the runtime version, but that can cause issues with tracy requesting invalid enums at runtime and I've seen This is the offending call: Cortex-Command-Community-Project/external/sources/tracy/public/tracy/TracyOpenGL.hpp Line 103 in 5353f45
The changes in this PR handle commonalities. |
Does implementing GLES at runtime give us any real benefit? Does that just mean we can query for the best API at startup instead of (necessarily) providing different binaries, or is there some other reason? |
No description provided.