Skip to content

GL updates #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2024
Merged

GL updates #37

merged 2 commits into from
Jan 24, 2024

Conversation

janisozaur
Copy link
Contributor

No description provided.

Copy link
Contributor

@Causeless Causeless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments, but I don't know much about shader programming so feel free to swat em away 🫡

@Causeless Causeless requested a review from HeliumAnt January 24, 2024 14:54
@janisozaur
Copy link
Contributor Author

janisozaur commented Jan 24, 2024

I addressed the comments. Yes, this is for GLES support, already implemented: d137251 (development...gles-v2)

I'd like to implement it either as runtime switch or as a compile time one. I prefer the runtime version, but that can cause issues with tracy requesting invalid enums at runtime and I've seen glGetInteger crash the process, so this would need to addressed first.

This is the offending call:

The changes in this PR handle commonalities.

@janisozaur janisozaur mentioned this pull request Jan 24, 2024
@Causeless
Copy link
Contributor

Does implementing GLES at runtime give us any real benefit? Does that just mean we can query for the best API at startup instead of (necessarily) providing different binaries, or is there some other reason?

@Causeless Causeless enabled auto-merge January 24, 2024 21:20
@Causeless Causeless added this pull request to the merge queue Jan 24, 2024
Merged via the queue into development with commit 59773a9 Jan 24, 2024
@Causeless Causeless deleted the gl-updates branch January 24, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants