Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DotNet in docker container #691

Merged
merged 2 commits into from
Sep 23, 2023
Merged

DotNet in docker container #691

merged 2 commits into from
Sep 23, 2023

Conversation

mscottford
Copy link
Member

  • Makes adjustments to how docker container image is built
  • Makes sure that CI only attempts to build the docker container if all of the tests pass
  • Makes sure that CI runs some smoke tests against the docker container before publishing the built image

Addresses the following issues:

@mscottford
Makes adjustments to how the container is structured
ec54fcd 
* The final container is based on the .NET SDK image, because the dotnet language agent requires the `dotnet` sdk to be available.
* JDK is installed via `apt`
* `dotnet-CycloneDX` is installed using `dotnet tool install`
@mscottford
Makes adjustments to production Docker container steps
c09eddb 
* Moves docker container build until after all tests have passed
* Adds smoke tests for the container that will need to succeed before the container image is published to the registry
@mscottford mscottford changed the title Dotnet dockerfile DotNet in docker container Sep 23, 2023
@mscottford mscottford merged commit 8a50fb9 into main Sep 23, 2023
@mscottford mscottford deleted the dotnet-dockerfile branch September 23, 2023 23:05
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@mscottford