-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grub console settings with bootupd bootloader updates #1671
Comments
bootupd doesn't support updating the static configs right now, though it should. |
Right. I imagine a future where we want that in which case the current structure that we have (per the description above) is going to be lossy. |
Ah, coreos/bootupd#609 only does the tracking, not the updating part. I had misunderstood that. |
@travier right. Either way let's assume that one day the static grub configs will get updated. Since nothing has shipped that uses Here is one proposal:
Another proposal would be making
|
Making it part of the main bootupd config seems like a good idea as well as it's definitely something that will be used on all platforms. |
The second one seems sane to me. One thing to bear in mind is that bootupd is also now used by anaconda if present, and ultimately I think we want to align the behavior and logic of console configuration with that too (the overlap/dup between osbuild/anaconda is another thread). |
OK. Copying forward the proposal and starting to work on the checklist:
|
In coreos/fedora-coreos-tracker#1671 we decided to use a non-static grub file for console configuration named console.cfg.
This will allow users or distro builders place console settings here that will get picked up on boot. This was discussed as part of coreos/fedora-coreos-tracker#1671
See coreos/fedora-coreos-tracker#1671 where we discovered that having this be a static config delivered by bootupd was a bad idea. Instead we'll have something else create a file in /boot/grub2/console.cfg (most likely osbuild/osbuild#1589) and we'll have the bootupd static grub configs source it (coreos/bootupd#619).
In coreos/fedora-coreos-tracker#1671 we decided to have this file be `console.cfg` and not `30_console.cfg`.
See coreos/fedora-coreos-tracker#1671 where we discovered that having this be a static config delivered by bootupd was a bad idea. Instead we'll have something else create a file in /boot/grub2/console.cfg (most likely osbuild/osbuild#1589) and we'll have the bootupd static grub configs source it (coreos/bootupd#619).
In coreos/fedora-coreos-tracker#1671 we decided to use a non-static grub file for console configuration named console.cfg.
In coreos/fedora-coreos-tracker#1671 we decided to have this file be `console.cfg` and not `30_console.cfg`.
In coreos/fedora-coreos-tracker#1671 we decided to have this file be `console.cfg` and not `30_console.cfg`.
In coreos/fedora-coreos-tracker#1671 we decided to have this file be `console.cfg` and not `30_console.cfg`.
See coreos/fedora-coreos-tracker#1671 where we discovered that having this be a static config delivered by bootupd was a bad idea. Instead we'll have something else create a file in /boot/grub2/console.cfg (most likely osbuild/osbuild#1589) and we'll have the bootupd static grub configs source it (coreos/bootupd#619).
This has a backport of coreos/bootupd#619 to support GRUB console settings in console.cfg. Seee coreos/fedora-coreos-tracker#1671
This has a backport of coreos/bootupd#619 to support GRUB console settings in console.cfg. Seee coreos/fedora-coreos-tracker#1671
I think I can close this out now. |
See coreos/fedora-coreos-tracker#1671 where we discovered that having this be a static config delivered by bootupd was a bad idea. Instead we'll have something else create a file in /boot/grub2/console.cfg (most likely osbuild/osbuild#1589) and we'll have the bootupd static grub configs source it (coreos/bootupd#619).
In the OSBuild workflow we are using bootupd to do the bootloader install along with
--with-static-configs
which will copy into place the files under/usr/lib/bootupd/grub2-static/configs.d/
In coreos/fedora-coreos-config#2769 we added the configs needed for CoreOS which included
30_console.cfg
with these contents:We then updated
coreos-installer
to update that config with the platform specific console settings (i.e. like a find/replace onCONSOLE-SETTINGS-START
/CONSOLE-SETTINGS-END
) and are in the process of adding a stage to OSBuild that will do the same.However, a really good question here is what will happen on these provisioned machines the next time the bootloader is updated? Will
/boot/grub2/30_console.cfg
just get overwritten bybootupd
with the static version that is in/usr/lib/bootupd/grub2-static/configs.d/30_console.cfg
, thus losing the applied console settings?We may need to adjust our strategy to have the static config be something like:
and then have our disk building processes (not
bootupd
) createconsole.cfg
with:This ticket came out of a conversation I had with @travier
The text was updated successfully, but these errors were encountered: