overlay.d/40grub: delete 30_console.cfg file #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See coreos/fedora-coreos-tracker#1671 where we discovered that having this be a static config delivered by bootupd was a bad idea. Instead we'll have something else create a file in /boot/grub2/console.cfg (most likely osbuild/osbuild#1589) and we'll have the bootupd static grub configs source it (coreos/bootupd#619).
We'll now prefer console.cfg if it exists over grub.cfg.
dustymabe
force-pushed
the
dusty-delete-grub-console-cfg
branch
from
b7151c0
to
fbfd715
Compare
|
ok this is looking good in testing. lifting draft |
jlebon
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See coreos/fedora-coreos-tracker#1671 where we discovered that having this be a static config delivered by bootupd was a bad idea.
Instead we'll have something else create a file in /boot/grub2/console.cfg (most likely osbuild/osbuild#1589) and we'll have the bootupd static grub configs source it (coreos/bootupd#619).