Move comments in systemd services to own line #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comments in systemd services at the end of lines cause unnecessary warning messges: Failed to add dependency on on, ignoring: Invalid argument Failed to add dependency on dracut, ignoring: Invalid argument Failed to add dependency on 053+, ignoring: Invalid argument The services would still start so this is a cosmetic change only.
lucab
pushed a commit
that referenced
this pull request
Oct 14, 2021
cgwalters
pushed a commit
to cgwalters/fedora-coreos-config
that referenced
this pull request
Nov 8, 2021
c4rt0
pushed a commit
to c4rt0/fedora-coreos-config
that referenced
this pull request
Mar 27, 2023
We especially want: - coreos#1283 for https://bugzilla.redhat.com/show_bug.cgi?id=1977949 - coreos#1299 for https://bugzilla.redhat.com/show_bug.cgi?id=1990506 - coreos#1300 for openshift/os#659 - coreos#1302 for https://bugzilla.redhat.com/show_bug.cgi?id=2005507 ``` Benjamin Gilbert (1): manifests/fedora-coreos-base: explicitly add xen-blkfront to initrd Dusty Mabe (6): denylist: snooze rpmostree.install-uninstall for F35/F36 streams denylist: snooze ostree.hotfix in rawhide on aarch64 Revert "denylist: snooze rpmostree.install-uninstall for F35/F36 streams" denylist: remove snooze on podman.base denylist: don't run tracker coreos#997 workaround test on rawhide/next-devel/next .cci.jenkinsfile: use buildfetch instead of buildprep John Allberg (1): coreos#975: bootup: ostree-remount may race with systemd-backlight and fail Jonathan Lebon (1): Move coreos-check-ignition-config from 15fcos to 05core Joseph Marrero (1): Fix: coreos-livepxe-rootfs to print rootfs_url Renata Ravanelli (1): Bug 1990506: Add dracut module for scsi rules Sohan Kunkerkar (2): lockfiles: fast-track Ignition v2.12.0-3 15fcos: change the location of Ignition report Timothée Ravier (5): overlay: Remove workaround keeping /boot RW for kdump Re-enable kdump test on QEMU, x86_64 & aarch64 only tests/kdump: Only run on x86_64 for now tests/kdump: Remove workraound keeping /boot RW tests/kdump: Use crashkernel=256M ```
c4rt0
pushed a commit
to c4rt0/fedora-coreos-config
that referenced
this pull request
Mar 27, 2023
ci: Enable all metal kola tests for SCOS
HuijingHei
pushed a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Oct 10, 2023
HuijingHei
pushed a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments in systemd services at the end of lines cause unnecessary
warning messges:
Failed to add dependency on on, ignoring: Invalid argument
Failed to add dependency on dracut, ignoring: Invalid argument
Failed to add dependency on 053+, ignoring: Invalid argument
The services would still start so this is a cosmetic change only.