Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/kdump: Use test definition from fedora-coreos-config #659

Closed
wants to merge 1 commit into from

Conversation

travier
Copy link
Member

@travier travier commented Oct 20, 2021

This also picks up the changes from there (keep it QEMU & x86_64 only for now).

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2021
@travier
Copy link
Member Author

travier commented Oct 20, 2021

/hold
This needs coreos/fedora-coreos-config#1300 to land in FCOS first.
I will also create a BZ to be able to backport the FCOS fix to 4.9.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2021
@jlebon
Copy link
Member

jlebon commented Oct 20, 2021

I've got a submodule bump going in #658. I can rebump it again to pick up the FCOS change. Just waiting for coreos/fedora-coreos-config#1299 to get in as well. (Anyway, CI is currently broken.)

jlebon added a commit to jlebon/os that referenced this pull request Oct 20, 2021
We especially want:
- coreos/fedora-coreos-config#1283 for
  https://bugzilla.redhat.com/show_bug.cgi?id=1977949
- coreos/fedora-coreos-config#1299 for
  https://bugzilla.redhat.com/show_bug.cgi?id=1990506
- coreos/fedora-coreos-config#1300 for
  openshift#659

```
Benjamin Gilbert (1):
      manifests/fedora-coreos-base: explicitly add xen-blkfront to initrd

Dusty Mabe (5):
      denylist: snooze rpmostree.install-uninstall for F35/F36 streams
      denylist: snooze ostree.hotfix in rawhide on aarch64
      Revert "denylist: snooze rpmostree.install-uninstall for F35/F36 streams"
      denylist: remove snooze on podman.base
      denylist: don't run tracker openshift#997 workaround test on rawhide/next-devel/next

John Allberg (1):
      openshift#975: bootup: ostree-remount may race with systemd-backlight and fail

Jonathan Lebon (1):
      Move coreos-check-ignition-config from 15fcos to 05core

Renata Ravanelli (1):
      Bug 1990506: Add dracut module for scsi rules

Sohan Kunkerkar (2):
      lockfiles: fast-track Ignition v2.12.0-3
      15fcos: change the location of Ignition report

Timothée Ravier (5):
      overlay: Remove workaround keeping /boot RW for kdump
      Re-enable kdump test on QEMU, x86_64 & aarch64 only
      tests/kdump: Only run on x86_64 for now
      tests/kdump: Remove workraound keeping /boot RW
      tests/kdump: Use crashkernel=256M
```
jlebon added a commit to jlebon/os that referenced this pull request Oct 26, 2021
We especially want:
- coreos/fedora-coreos-config#1283 for
  https://bugzilla.redhat.com/show_bug.cgi?id=1977949
- coreos/fedora-coreos-config#1299 for
  https://bugzilla.redhat.com/show_bug.cgi?id=1990506
- coreos/fedora-coreos-config#1300 for
  openshift#659
- coreos/fedora-coreos-config#1302 for
  https://bugzilla.redhat.com/show_bug.cgi?id=2005507

```
Benjamin Gilbert (1):
      manifests/fedora-coreos-base: explicitly add xen-blkfront to initrd

Dusty Mabe (6):
      denylist: snooze rpmostree.install-uninstall for F35/F36 streams
      denylist: snooze ostree.hotfix in rawhide on aarch64
      Revert "denylist: snooze rpmostree.install-uninstall for F35/F36 streams"
      denylist: remove snooze on podman.base
      denylist: don't run tracker openshift#997 workaround test on rawhide/next-devel/next
      .cci.jenkinsfile: use buildfetch instead of buildprep

John Allberg (1):
      openshift#975: bootup: ostree-remount may race with systemd-backlight and fail

Jonathan Lebon (1):
      Move coreos-check-ignition-config from 15fcos to 05core

Joseph Marrero (1):
      Fix: coreos-livepxe-rootfs to print rootfs_url

Renata Ravanelli (1):
      Bug 1990506: Add dracut module for scsi rules

Sohan Kunkerkar (2):
      lockfiles: fast-track Ignition v2.12.0-3
      15fcos: change the location of Ignition report

Timothée Ravier (5):
      overlay: Remove workaround keeping /boot RW for kdump
      Re-enable kdump test on QEMU, x86_64 & aarch64 only
      tests/kdump: Only run on x86_64 for now
      tests/kdump: Remove workraound keeping /boot RW
      tests/kdump: Use crashkernel=256M
```
@travier
Copy link
Member Author

travier commented Nov 15, 2021

This will need an update for coreos/fedora-coreos-config#1338

@miabbott
Copy link
Member

This will need an update for coreos/fedora-coreos-config#1338

I think once coreos/fedora-coreos-config#1322 lands, we can do more broad sharing of the FCOS tests and won't need to pick them individually

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2021

@travier: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/build-test-qemu 6937f4d link true /test build-test-qemu

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@miabbott
Copy link
Member

This looks like it is superceded by #678

@travier
Copy link
Member Author

travier commented Nov 22, 2021

Closing in favor of #678.
/close

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 22, 2021

@travier: Closed this PR.

In response to this:

Closing in favor of #678.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Nov 22, 2021
@travier travier deleted the kdumptest branch November 22, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants