tests/kola: add test for separate /var mount #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
approved these changes
Aug 28, 2020
| #!/bin/bash | ||
| set -xeuo pipefail | ||
|
|
||
| # restrict to qemu for now because the primary disk path is platform-dependent |
There was a problem hiding this comment.
Not strictly related to this PR but I think we really need to introduce something like /dev/disk/coreos-root or so.
jlebon
added a commit
to jlebon/ostree
that referenced
this pull request
Aug 28, 2020
That test will not make it into the fedora-coreos-config repo until the libostree fix gets percolated down. PR is: coreos/fedora-coreos-config#586 But we want to make sure that the fix does work and that we don't regress on it. So manually fetch it for now.
|
CI here will fail until ostreedev/ostree#2186 reaches FCOS. |
jlebon
added a commit
to jlebon/ostree
that referenced
this pull request
Aug 28, 2020
That test will not make it into the fedora-coreos-config repo until the libostree fix gets percolated down. PR is: coreos/fedora-coreos-config#586 But we want to make sure that the fix does work and that we don't regress on it. So manually fetch it for now.
We regressed on this a few times. Let's add a test for it.
cgwalters
force-pushed
the
pr/var-mount
branch
from
0c5d20b
to
01d5ae2
Compare
|
I rebased 🏄♂️ this now that we have #596 |
|
OK hmm that last CI run did successfully get the latest ostree and the new test passed; the upgrade run just flaked downloading an image. |
|
Hooray, green here! Let's make sure we don't break this again. |
cgwalters
added a commit
to cgwalters/ostree
that referenced
this pull request
Sep 3, 2020
This was referenced Sep 3, 2020
c4rt0
pushed a commit
to c4rt0/fedora-coreos-config
that referenced
this pull request
Mar 27, 2023
ci: add debug information about cosa/rpm-ostree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We regressed on this a few times. Let's add a test for it.