This repository was archived by the owner on Sep 18, 2020. It is now read-only.
pkg/analytics: Remove Google Analytics tracking #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euank
reviewed
Oct 17, 2017
| beforeRebootAnnotations flagutil.StringSliceFlag | ||
| afterRebootAnnotations flagutil.StringSliceFlag | ||
| kubeconfig = flag.String("kubeconfig", "", "Path to a kubeconfig file. Default to the in-cluster config if not provided.") | ||
| analyticsEnabled = flag.Bool("analytics", true, "Send analytics to Google Analytics") |
Contributor
There was a problem hiding this comment.
note, this will break people with -analytics=false set; it might be worth leaving the flag and printing a warning if it's set for a few releases.
Member
Author
There was a problem hiding this comment.
I was thinking a release note mentioning its removal in v0.4.0, but not opposed to leaving it
Contributor
There was a problem hiding this comment.
Make sure to call it out as a breaking change. I'm okay either way if it's called out correctly.
Since we don't currently have a process for that though, it might be better to err on the side of giving longer notice.
dghubble
force-pushed
the
remove-analytics
branch
from
dbd6768 to
74e5970
Compare
Member
Author
|
Added change to show a warning if |
euank
approved these changes
Oct 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never even look at these analytics and its unclear what value they provide. No need to tradeoff being creepy if it isn't providing clear value.