Retain -analytics tag to avoid breakage, but warn on use

Author: dghubble

cmd/update-operator/main.go

@@ -4,6 +4,7 @@ import (
 	"flag"
 	"fmt"
 	"os"
+	"strconv"
 
 	"github.com/coreos/pkg/flagutil"
 	"github.com/golang/glog"
@@ -20,13 +21,15 @@ var (
 	autoLabelContainerLinux = flag.Bool("auto-label-container-linux", false, "Auto-label Container Linux nodes with agent=true (convenience)")
 	printVersion            = flag.Bool("version", false, "Print version and exit")
 	// deprecated
-	manageAgent    = flag.Bool("manage-agent", false, "Manage the associated update-agent")
-	agentImageRepo = flag.String("agent-image-repo", "quay.io/coreos/container-linux-update-operator", "The image to use for the managed agent, without version tag")
+	analyticsEnabled optValue
+	manageAgent      = flag.Bool("manage-agent", false, "Manage the associated update-agent")
+	agentImageRepo   = flag.String("agent-image-repo", "quay.io/coreos/container-linux-update-operator", "The image to use for the managed agent, without version tag")
 )
 
 func main() {
 	flag.Var(&beforeRebootAnnotations, "before-reboot-annotations", "List of comma-separated Kubernetes node annotations that must be set to 'true' before a reboot is allowed")
 	flag.Var(&afterRebootAnnotations, "after-reboot-annotations", "List of comma-separated Kubernetes node annotations that must be set to 'true' before a node is marked schedulable and the operator lock is released")
+	flag.Var(&analyticsEnabled, "analytics", "Send analytics to Google Analytics")
 
 	flag.Set("logtostderr", "true")
 	flag.Parse()
@@ -35,6 +38,10 @@ func main() {
 		glog.Fatalf("Failed to parse environment variables: %v", err)
 	}
 
+	if analyticsEnabled.present {
+		glog.Warning("Use of -analytics is deprecated and will be removed. Google Analytics will not be enabled.")
+	}
+
 	// respect KUBECONFIG without the prefix as well
 	if *kubeconfig == "" {
 		*kubeconfig = os.Getenv("KUBECONFIG")
@@ -78,3 +85,20 @@ func main() {
 		glog.Fatalf("Error while running %s: %v", os.Args[0], err)
 	}
 }
+
+// optValue is a flag.Value that detects whether a user passed a flag directly.
+type optValue struct {
+	value   bool
+	present bool
+}
+
+func (o *optValue) Set(s string) error {
+	v, err := strconv.ParseBool(s)
+	o.value = v
+	o.present = true
+	return err
+}
+
+func (o *optValue) String() string {
+	return strconv.FormatBool(o.value)
+}