Update coralogix-autoinstrumentation from Lambda instrumentation v0.44 to v0.50.3
#24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lient URL is the empty string (open-telemetry#2399) Issue open-telemetry#2389 showed that this instrumentation would crash on a Redis client configured with {url: ''} (an empty string). The crash was fixed in open-telemetry#2397. This change avoids the once-crashy code, and hence the diag.error spam, by using the same guard before attempting to parse the configured client URL that the Redis client itself does, if (options?.url), Refs: open-telemetry#2389
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
…also fix test flakiness (open-telemetry#2421) This is a follow-up on open-telemetry#2408 (comment) to update one more usage of SpanKind.* to testUtils.OtlpSpanKind.*. While testing this locally I also noticed that the instr-express tests using runTestFixture are flaky. The issue is that TestCollector#sortedSpans can get the span ordering wrong when spans start in the same millisecond (the resolution of span.startTimeUnixNano). This happens with Express middleware spans on a fast machine. I've updated sortedSpans to fallback to using span.parentSpanId to attempt to get more reliable sorting.
…ace (open-telemetry#2337) Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
…pen-telemetry#2319) This PR adds a new utility (getRouterPath) to recursively search the (possibly nested) parameterised router path when getting the layer metadata. This only affects the span name, not the http.route attribute of the span. http.route is still showing the mount path. (Active discussion on this: Express instrumentation does not properly handle router usage open-telemetry#1993 (comment)) Uses route primarily to assign the requestHandler span name instead of layerPath. layerPath does not represent the full path, only the path of the last matching router when nested routers are used. Co-authored-by: Abhijeet Prasad <devabhiprasad@gmail.com> Co-authored-by: Jamie Danielson <jamiedanielson@honeycomb.io> Co-authored-by: Jamie Danielson <jamieedanielson@gmail.com>
…o work (open-telemetry#2446) Co-authored-by: Trent Mick <trentm@gmail.com>
Per https://learn.microsoft.com/en-us/sql/linux/sql-server-linux-configure-environment-variables SA_PASSWORD (without the prefix) is deprecated.
…open-telemetry#2380) Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Co-authored-by: David Luna <david.luna@elastic.co>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
plugins/node/opentelemetry-instrumentation-mysql2/test/mysql.test.ts
Dismissed
Show dismissed
Hide dismissed
plugins/node/opentelemetry-instrumentation-mysql2/test/mysql.test.ts
Dismissed
Show dismissed
Hide dismissed
plugins/node/opentelemetry-instrumentation-pg/test/fixtures/use-pg.mjs
Dismissed
Show dismissed
Hide dismissed
plugins/node/opentelemetry-instrumentation-pg/test/fixtures/use-pg.mjs
Dismissed
Show dismissed
Hide dismissed
plugins/node/opentelemetry-instrumentation-pg/test/pg-pool.test.ts
Dismissed
Show dismissed
Hide dismissed
plugins/node/opentelemetry-instrumentation-pg/test/pg-pool.test.ts
Dismissed
Show dismissed
Hide dismissed
plugins/node/opentelemetry-instrumentation-pg/test/pg.test.ts
Dismissed
Show dismissed
Hide dismissed
povilasv
approved these changes
Mar 19, 2025
douglascamata
merged commit 3641dc4
into
coralogix-autoinstrumentation
18 of 35 checks passed
douglascamata
added a commit
to coralogix/opentelemetry-lambda
that referenced
this pull request
Mar 19, 2025
Fixes ES-492. Required after the changes in coralogix/opentelemetry-js#5 and coralogix/opentelemetry-js-contrib#24.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ES-492.
Which problem is this PR solving?
This PR updates
coralogix-autoinstrumentationfrom Lambda instrumentation v0.44 to v0.50.3.Tested paired with the changes in coralogix/opentelemetry-js#4 through the lambda-telemetry-infra-test toolset.
Short description of the changes
The only notable change is:
faas.coldstart(feat: Record AWS Lambda coldstarts open-telemetry/opentelemetry-js-contrib#2403)