Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use codecov token when uploading reports #2468

Merged

Conversation

pichlermarc
Copy link
Member

Description

See open-telemetry/opentelemetry-js#5053 in the core repo.

The same problem exists here - commits on main are not created in codecov because we're missing the token, which means that the reports on the PRs are hundreds of commits behind. (see recent run on main https://github.com/open-telemetry/opentelemetry-js-contrib/actions/runs/11241062146/job/31251798449#step:11:80)

@pichlermarc pichlermarc requested a review from a team as a code owner October 9, 2024 10:23
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.74%. Comparing base (dfb2dff) to head (9dd142e).
Report is 256 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2468      +/-   ##
==========================================
- Coverage   90.97%   90.74%   -0.24%     
==========================================
  Files         146      156      +10     
  Lines        7492     7723     +231     
  Branches     1502     1588      +86     
==========================================
+ Hits         6816     7008     +192     
- Misses        676      715      +39     

see 76 files with indirect coverage changes

@pichlermarc pichlermarc merged commit 3c7c0da into open-telemetry:main Oct 10, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants