enhancement: don't allow wallet names to start with '@' #3202 #3513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adds crypto shim for ios/android * removes react-native-get-random-values
* removes app-extension from recoil * adds eslint rule * re-export useBreakpoints from recoil and pass it through * fixes * removes old breakpoints file
* Delete chats with a new queue * fixed stuff
* fox build * centered
* Fixed double notification * added fix
… user profile (coral-xyz#3140)" (coral-xyz#3143) This reverts commit c2a5cab.
* adjustments * fix mnemonic input * fix scrolling on secret recovery phrase * cleanup and fix * fix
Co-authored-by: Salim Karim <metasal@gmx.com>
* Moved Searchbox to react-common * fixed import
* wip * make messages list look good * adds chat support * wipwip hooray * hook up data * hook it all up
* fix dumb eslint rootdir warnings * removes metro app config from main one * fixes annoying eslint
* nft detail updates * fix nfts not loading * updates types * fixes
* cleanup * cleanup
|
@jeivardan is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
hkirat
suggested changes
Mar 31, 2023
...ages/app-extension/src/components/Unlocked/Settings/YourAccount/EditWallets/RenameWallet.tsx
Outdated
Show resolved
Hide resolved
getusha
suggested changes
Apr 6, 2023
| } else { | ||
| setError(false); | ||
| setErrorMessage(""); | ||
| setIsPrimaryDisabled(walletName.trim() === "" ? true : false); |
There was a problem hiding this comment.
Suggested change
| setIsPrimaryDisabled(walletName.trim() === "" ? true : false); | |
| setIsPrimaryDisabled(walletName.trim() === ""); |
We can simplify this, it just gives confusion... right?
There was a problem hiding this comment.
Yeah! Simplified it. Thanks for the suggestion.
packages/common/src/utils.ts
Outdated
| */ | ||
| export function isValidWalletName(walletName: string): boolean { | ||
| //regex check to not allow wallet names to start with '@' | ||
| let regExp = new RegExp("^(?!@.*$).*"); |
There was a problem hiding this comment.
This is too generic variable name, can we improve it?
There was a problem hiding this comment.
Yep it is too generic and I've made the changes
| } else { | ||
| setError(false); | ||
| setErrorMessage(""); | ||
| setIsNextDisabled(walletName.trim() === "" ? true : false); |
There was a problem hiding this comment.
Suggested change
| setIsNextDisabled(walletName.trim() === "" ? true : false); | |
| setIsNextDisabled(walletName.trim() === ""); |
The variable name in walletName check regEx is updated to be more descriptive. Additionally, a minor change was made to improve the readability of the code.
armaniferrante
force-pushed
the
master
branch
from
f4232de to
33f7b8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3202 in both create and rename wallet