Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't allow wallet names to start with @ #3202

Open
wentokay opened this issue Mar 7, 2023 · 3 comments
Open

don't allow wallet names to start with @ #3202

wentokay opened this issue Mar 7, 2023 · 3 comments
Assignees
@noobie7
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed priority 3

Comments

@wentokay
Copy link
Collaborator

wentokay commented Mar 7, 2023

as it could cause confusion with usernames in future
@wentokay wentokay added the enhancement New feature or request label Mar 7, 2023
@armaniferrante armaniferrante added priority 2 help wanted Extra attention is needed good first issue Good for newcomers labels Mar 7, 2023
@wentokay wentokay mentioned this issue Mar 7, 2023
Merged
4 tasks
@noobie7
Copy link

noobie7 commented Mar 28, 2023

Can this be assigned to me?

@wentokay
Copy link
Collaborator Author

it's yours @noobie7! thanks

@jeivardan jeivardan mentioned this issue Mar 31, 2023
Closed
@shubhiscoding
Copy link

shubhiscoding commented Apr 3, 2024 •
edited
Loading

hii @wentokay @armaniferrante please review this PR #4306
In this PR I have made necessary changes to avoid user from naming there wallet starting from '@'
image

@shubhiscoding shubhiscoding mentioned this issue Jun 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noobie7 noobie7

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed priority 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enhancement: don't allow wallet names to start with '@' #3202 jeivardan/backpack
4 participants
@armaniferrante @noobie7 @shubhiscoding @wentokay