Skip to content

Fix login panel vertical positioning issue #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Matt-Yorkley
Copy link
Contributor

Closes #278.

A few CSS tweaks so the vertical positioning of the login modal doesn't jump around when it's inner content changes in height.

@sauloperez
Copy link
Collaborator

can you share a screenshot, please?

@Matt-Yorkley
Copy link
Contributor Author

Matt-Yorkley commented Jun 22, 2018

BEFORE:

screenshot from 2018-06-22 17-40-39
screenshot from 2018-06-22 17-40-59

AFTER:

screenshot from 2018-06-22 17-37-12
screenshot from 2018-06-22 17-37-33

@markets
Copy link
Collaborator

markets commented Jul 5, 2018

Hi guys 👋, now that #388 is merged, I think we can close this PR (and the classic #278 😛).

@enricostano enricostano closed this Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants