-
Notifications
You must be signed in to change notification settings - Fork 69
Optimised first pages on mobile #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
good job @mllocs! 👍 do you think this branch overlaps with #385 (a fix for the classic #278)? I think so, maybe we can try to coordinate with @Matt-Yorkley in order to port/integrate his changes (if needed) here? What do you think guys? |
Hey @markets, yes, it totally overlaps with #385, good catch. Here I'm also fixing other issues, sorry for mixing it up..., here I'm getting rid of |
app/assets/stylesheets/_footer.scss
Outdated
@@ -63,6 +63,7 @@ | |||
& { | |||
background-color: transparent; | |||
border: 1px solid white; | |||
padding: 4px 8px |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔚 ;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mllocs minor comment added, but 👍
@mllocs Ok, so my other PR for the login modal might not be needed then. I notice you've used |
Deployed on staging, not sure about performance improvement but I found the following zoomed background image on mobile: Is that normal @mllocs ? EDIT: in EDIT2: actually I see a small performance boost |
@enricostano good catch, fixed ;) @Matt-Yorkley on your suggestion, I tried to use the same percentage in the top attribute for both big screens and mobile but it didn't look well, on big screens there was too much empty space :) |
Tested on |
Use a smaller background images on mobile devices and optimised the current one.
Other minor details to improve the look of the "first pages" (Home and Login).