fix: update Vite config for delivery function examples [EXT-6273] #9585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ecommerce-app-base-components canceled.
|
|
|
||
| type InstallationParameters = { | ||
| apiEndpoint: string; | ||
| url: string; | ||
| }; | ||
|
|
||
| type EventHandler = FunctionEventHandler<FunctionEventType, InstallationParameters>; | ||
| type QueryHandler = FunctionEventHandler<'graphql.query', InstallationParameters>; | ||
| type FieldMappingHandler = FunctionEventHandler<'graphql.field.mapping'>; | ||
| type QueryHandler = FunctionEventHandler<FunctionTypeEnum.GraphqlQuery, InstallationParameters>; |
| @@ -41,19 +39,19 @@ | |||
| ] | |||
| }, | |||
| "devDependencies": { | |||
| "@contentful/app-scripts": "1.33.2", | |||
| "@contentful/app-scripts": "^2.3.0", | |||
There was a problem hiding this comment.
Nice! I believe that's add-locations release!
There was a problem hiding this comment.
Yes, this should bump all of these examples so they'll have that available!
| "jsx": "react" | ||
| }, | ||
| "include": ["./src/**/*.ts", "./setupTests.ts", "./functions/**/*.ts"] | ||
| "exclude": ["functions"] |
There was a problem hiding this comment.
This is because build:functions uses a different tsc?
There was a problem hiding this comment.
Exactly! I ended up updating this example to follow the convention we had in some examples where we have separate tsconfigs for the frontend app and then the functions directory
BobHemphill76
approved these changes
Mar 20, 2025
BasKiers
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We updated the example apps to use Vite instead of CRA/react-scripts in this PR. However, a few things were missed, so this PR aims to clean those up.
Approach
Here's an overview of the changes:
Vite updates
./buildinstead of the default./dist. This is because thebuild-functionsscript from the@contentful/app-scriptspackage expects this to be the name for the build directory/// <reference types="vitest/config" />when using Vitest, adding the triple slash command as documented herestartscript in package.json in addition to todevtsconfig.jsonupdatestsconfigand the associatedreact-app-env.d.tsfile; add any necessary configuration after removing thattsconfig.jsonlike our function templatesContentful package dependency updates
@contentful/app-scriptsand@contentful/node-apps-toolkitFunctionTypeEnuminstead of string valuesDocumentation updates
Example-specific changes
The
function-mock-shopapp had some mistakes copied from another app in thepackage.json file, so I've addressed those.The
native-external-references-tmdbexample needed some additional updates in the test files to move from Jest to Vitest.Testing steps
I tested these locally in the apps repo and also tested them using CCA according these instructions
Breaking Changes
Dependencies and/or References
Deployment