Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/upgrade example app to vite [INTEG-2434] #9524

Merged
merged 16 commits into from
Mar 6, 2025

Conversation

david-shibley-contentful
Copy link
Contributor

Purpose

Approach

Testing steps

Breaking Changes

Dependencies and/or References

Deployment

@david-shibley-contentful david-shibley-contentful requested review from a team as code owners March 5, 2025 21:34
Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for ecommerce-app-base-components canceled.

Name Link
🔨 Latest commit 510506d
🔍 Latest deploy log https://app.netlify.com/sites/ecommerce-app-base-components/deploys/67c8c3624f23690008d60f05

@wiz-inc-38d59fb8d7
Copy link

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities 1 Medium
Data Finding Sensitive Data
Secret Finding Secrets
IaC Misconfiguration IaC Misconfigurations
Total 1 Medium

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@david-shibley-contentful david-shibley-contentful changed the title Feat/upgrade example app to vite Feat/upgrade example app to vite [INTEG-2434] Mar 5, 2025
Copy link
Contributor

@mrlaessig mrlaessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 💯

Copy link
Contributor

@mgoudy91 mgoudy91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks great to me

@david-shibley-contentful david-shibley-contentful merged commit 22c492e into master Mar 6, 2025
17 of 18 checks passed
@david-shibley-contentful david-shibley-contentful deleted the feat/upgrade-example-app-to-vite branch March 6, 2025 16:01
@@ -1,29 +1,29 @@
{
"name": "mockshop-function",
"name": "@contentful/editor-assignment-example",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

potential mismatch here

"test": "react-scripts test",
"dev": "vite",
"build": "vite build",
"test": "vitest",
"eject": "react-scripts eject",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove

"eject": "react-scripts eject",
"start": "vite",
"build": "vite build",
"eject": "vite eject",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't seem to find docs on this, I'm thinking it can just be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants