-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/upgrade example app to vite [INTEG-2434] #9524
Feat/upgrade example app to vite [INTEG-2434] #9524
Conversation
… of react scripts
✅ Deploy Preview for ecommerce-app-base-components canceled.
|
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything looks great to me
@@ -1,29 +1,29 @@ | |||
{ | |||
"name": "mockshop-function", | |||
"name": "@contentful/editor-assignment-example", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
potential mismatch here
"test": "react-scripts test", | ||
"dev": "vite", | ||
"build": "vite build", | ||
"test": "vitest", | ||
"eject": "react-scripts eject", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can remove
"eject": "react-scripts eject", | ||
"start": "vite", | ||
"build": "vite build", | ||
"eject": "vite eject", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't seem to find docs on this, I'm thinking it can just be removed
Purpose
Approach
Testing steps
Breaking Changes
Dependencies and/or References
Deployment