-
Couldn't load subscription status.
- Fork 100
feat: V2 Claims are now generated by default #1266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
updates the unit tests to work with V2 (all tests not passing yet)
Codecov Report❌ Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fix issues with doc tests
…c2pa-rs into gpeacock/v2_default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whew! That was a lot of work and very well done. I do (shocker) have a few suggestions and change requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates and the follow-ups in related PRs. I'm 👍 now.
feat: Use V2 Claims by default updates the unit tests to work with V2 by default bump min rust version to 1.86 The c2pa_rs SDK will now generate v2 claims by default aligning with the c2pa 2.2 specification> v1 claims (c2pa 1.4) generation is still available when requested but may be deprecated soon. Reading, validating and ingredient support for v1 claims will continue to be supported. We now support actions.parameters.ingredientIds to replace org.cai.ingredientIds (due to not owning cai.org. Neither of those parameter values will be written to the store action once they are converted to an ingredients array. added Actions try_from(str) to convert a string into an Action added an actions.ingredients() method to return hashed_uris since they are difficult to parse from values. updated make_test_images to produce v2 claims and updated all the known good v2 json samples ClaimDecoding Error now has a detailed message string to help with debugging. We support saving a store that was just loaded (no added signature) verify_after_sign setting now will verify the entire manifest, not just the signature. Fixed support for assertions vs databoxes in some cases. added test_to_and_from_jumbf for store disabled the unresolvable_did unit test since it was timing out on every run. Added DigitalSourceType Enum to builder Added Builder Create constructor using DigtitalSourceType Added Builder Update constructor for auto parent ingredient generation Added BuilderFlow Enum to keep track of the Builder constructor mode. Added Builder.add_action method to add an individual action from a serializable. do not generate the claim_generator field for v2 claims (claim_generator_info only) remove support for adding claim metadata (it will be ignored) fixed status tracker validation info/error message Added test_settings.toml with certs and trust lists for running unit tests. Updated many unit tests and integration tests for v2 compatibility and Settings api.
The c2pa_rs SDK will now generate v2 claims by default, aligning with the c2pa 2.2 specification. You can still generate v1 claims (c2pa 1.4), when requested but they will be deprecated soon. However, the SDK will continue to support reading and validating v1 claims and v1 ingredient claims.
verify_after_signsetting now verifies the entire manifest, not just the signature.claim_generatorfield for v2 claims (claim_generator_infoonly).For actions:
actions.parameters.ingredientIdsto replaceorg.cai.ingredientIdssince we don't owncai.orgdomain. Neither of those parameter values are written to the store action once they are converted to an ingredients array.try_from(str)to convert a string into an Actionactions.ingredients()method to returnhashed_urissince they are difficult to parse from values.Added the following to
Builder:DigitalSourceTypeenum.Createconstructor usingDigtitalSourceType.Updateconstructor for auto parent ingredient generation.BuilderFlowEnum to keep track of the Builder constructor mode.Builder.add_action()method to add an individual action from a serializable.Error messages:
ClaimDecodingerror now has a detailed message string to help with debugging.For tests:
test_settings.tomlwith certs and trust lists for running unit tests.test_to_and_from_jumbffor storeunresolvable_didunit test since it was timing out on every run.make_test_imagesto produce v2 claims and updated all the known good v2 JSON samples.