-
Couldn't load subscription status.
- Fork 100
feat: define DigitalSourceType as enum
#1260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ee9966b to
ceb354e
Compare
|
The failing test actually caught 2 issues: one that I should've untagged the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, It's great having this.
|
@gpeacock I'm not sure if it is a mistake in the spec, but the C2PA empty digital source type is defined as part of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I just have one more question about using the digsrctype prefixes. I'm not sure we need those in the context in which we would be using this:
"digtialSourceType": "digsrctype:digitalCapture".
vs
"digtialSourceType": "digitalCapture".
30328f8 to
3684ab9
Compare

Changes in this pull request
Define
Actions::source_typeas an enum so user's no longer need to manually specify the entire URL.Questions
Other(String)variant or ensure they are only what we support?digsrctype:digitalCapturein addition to the URL, which is technically incorrect according to the spec but offers a much more convenient JSON manifest/settings definition.Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.