refactor: Rename metadata to assertion_metadata #1261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok-nick
approved these changes
Jul 25, 2025
3 tasks
gpeacock
approved these changes
Jul 30, 2025
There was a problem hiding this comment.
We have all the assertions in the assertions crate, so they are already prefixed with assertions::Actions &etc. The label for this is c2pa.assertion.metadata so it just makes sense to call it AssertionMetadata. I don't think the actual user impact of the change will be much, given all the other changes there are for v2.
Closed
ok-nick
pushed a commit
that referenced
this pull request
Aug 11, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Renames metadata to assertion_metadata to open up metadata for
c2pa.metadataassertion and clarify confusionChecklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.