feat: Add metadata assertion and support for validation #1258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e metadata assertions
gpeacock
requested changes
Aug 5, 2025
gpeacock
approved these changes
Aug 11, 2025
Closed
ok-nick
pushed a commit
that referenced
this pull request
Aug 13, 2025
* feat: Add metadata struct and validation for allowed fields * fix: validation now follow specs * format: fix formatting * fix: Add support for custom metadata assertions and change validation logic * fix: Fix label being lost in to/from assertion conversion (json still broken) * fix: Resort to copying logic from_json_assertion and adding extra logic * fix: Revert changes to from_json_assertion * fix: Add some integration tests and change logic to retrieve duplicate metadata assertions * test: Add more tests and remove debug artifacts * docs: Add docs to methods * fix: Validate empty context and change logging * refactor: Rename Meta to Metadata * fix: Add special case for metadata * chore: Fix clippy * refactor: Use std Lazy Lock instead of macro, move it to labels * fix: Update old metadata integration test, input label before json_ld * docs: Add docs and fix mentions of URLs to be URIs * format: Fix format error --------- Co-authored-by: Gavin Peacock <gpeacock@adobe.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Supports c2pa.metadata assertion with validation of allowed fields
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.