fix: Support for BMFF V3 hashing options #1253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
validation of fixedBlockSize and fixedBlockSizes Merkle trees generation of fixedBlockSize Merkle trees
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1253 +/- ##
==========================================
+ Coverage 79.54% 80.05% +0.51%
==========================================
Files 151 151
Lines 42726 43204 +478
==========================================
+ Hits 33987 34588 +601
+ Misses 8739 8616 -123 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ok-nick
reviewed
Jul 23, 2025
PR comment change
gpeacock
reviewed
Jul 24, 2025
gpeacock
reviewed
Jul 24, 2025
gpeacock
requested changes
Jul 24, 2025
gpeacock
approved these changes
Jul 29, 2025
Closed
ok-nick
pushed a commit
that referenced
this pull request
Aug 11, 2025
* Support for BMFF Hash V3 validation of fixedBlockSize and fixedBlockSizes Merkle trees generation of fixedBlockSize Merkle trees * Bug fix for case when BMFF exclusion subset is using length with no offset * Setting to control Merkle tree storage * Change error message * More error checking PR comment change * Make settings fetch return error is not set * Add test for no fixed offset * Fix formatting * Check for conflicting block types * Fix error response for competing Merkle block types * Make spec responses * Allow 0 length fixed offset * A little cleanup * Make sure there is a recognized hash binding * Fix for some more edge cases * clippy fix --------- Co-authored-by: Gavin Peacock <gpeacock@adobe.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Support for validation of V3 features (fixed and variable sized mdat Merkle trees)
Support for generation of fixed size mdat Merkle trees
Fix for bug when top level exclusion is not followed immediately have by the top level box (subset exclusions)
Change HashRanges to be u64 by default to handle large mdata in 32 bit environments
Change streaming path to use safe_vec when generating intermediate stream
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.