Skip to content

Conversation

@cdmurph32
Copy link
Collaborator

@cdmurph32 cdmurph32 commented Jul 7, 2025

Changes in this pull request

  • Set longer timeout
  • Use Chrome for testing version 137 to show output
  • Explicitly set chrome-driver to use

@codecov
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.56%. Comparing base (47df42e) to head (f7e5592).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1202      +/-   ##
==========================================
+ Coverage   79.29%   79.56%   +0.26%     
==========================================
  Files         147      147              
  Lines       40701    40548     -153     
==========================================
- Hits        32274    32262      -12     
+ Misses       8427     8286     -141     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cdmurph32 cdmurph32 force-pushed the wasm_test_fix branch 2 times, most recently from f2b3ae6 to d3e25ea Compare July 7, 2025 18:21
 * Set longer timeout
 * Use Chrome for testing version 137 to show output
 * Explicitly set chrome-driver to use
@cdmurph32 cdmurph32 changed the title fix: T/S chrome driver fix: Fix wasm-pack yet again Jul 7, 2025
@cdmurph32 cdmurph32 marked this pull request as ready for review July 7, 2025 19:04
Copy link
Collaborator

@scouten-adobe scouten-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore the Clippy changes. Those should be fixed in either #1195 or #1204.

@cdmurph32 cdmurph32 merged commit 7618532 into main Jul 7, 2025
38 of 40 checks passed
@cdmurph32 cdmurph32 deleted the wasm_test_fix branch July 7, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants