Skip to content

Conversation

@gpeacock
Copy link
Collaborator

Clippy now forces inlined format values
This is a rework of Tania's changes directly into main

@codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 46.59091% with 47 lines in your changes missing coverage. Please review.

Project coverage is 79.56%. Comparing base (7618532) to head (e4688e4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cli/src/main.rs 5.55% 17 Missing ⚠️
make_test_images/src/compare_manifests.rs 0.00% 13 Missing ⚠️
sdk/src/reader.rs 20.00% 4 Missing ⚠️
cli/src/tree.rs 33.33% 2 Missing ⚠️
export_schema/src/main.rs 0.00% 2 Missing ⚠️
sdk/src/manifest_store_report.rs 0.00% 2 Missing ⚠️
sdk/src/store.rs 33.33% 2 Missing ⚠️
c2pa_c_ffi/src/c_api.rs 66.66% 1 Missing ⚠️
sdk/src/asset_handlers/gif_io.rs 0.00% 1 Missing ⚠️
sdk/src/builder.rs 85.71% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1195   +/-   ##
=======================================
  Coverage   79.56%   79.56%           
=======================================
  Files         147      147           
  Lines       40548    40543    -5     
=======================================
- Hits        32262    32259    -3     
+ Misses       8286     8284    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmathern
Copy link
Contributor

tmathern commented Jun 27, 2025

#1193 can be closed if this gets merged first... except if it's easier for @mauricefisher64 to merge mine in (into his PR), to avoid wrangling git conflicts. Your call! But feel free to close it if it's not used anymore.

@tmathern
Copy link
Contributor

Preapproving - but you missed some updates it seems:

error: variables can be used directly in the `format!` string
    --> sdk/src/store.rs:7730:9
     |
7730 |         println!("new_store: {}", new_store);
     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
     = note: `-D clippy::uninlined-format-args` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
     |
7730 -         println!("new_store: {}", new_store);
7730 +         println!("new_store: {new_store}");
     |

error: variables can be used directly in the `format!` string
    --> sdk/src/store.rs:7867:9
     |
7867 |         println!("new_store: {}", new_store);
     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
     |
7867 -         println!("new_store: {}", new_store);
7867 +         println!("new_store: {new_store}");
     |

error: could not compile `c2pa` (lib test) due to 2 previous errors

(I had to do multiple sweeps).

@gpeacock gpeacock closed this Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants