feat: impl Soft Binding assertion definition #1147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmathern
reviewed
Jun 5, 2025
ok-nick
force-pushed
the
ok-nick/soft-binding
branch
from
cca0a83 to
d189d86
Compare
gpeacock
requested changes
Jun 16, 2025
gpeacock
requested changes
Jul 9, 2025
…nick/soft-binding
gpeacock
requested changes
Aug 10, 2025
… suffix from related structs
gpeacock
approved these changes
Aug 11, 2025
3 tasks
Closed
ok-nick
added a commit
that referenced
this pull request
Aug 13, 2025
* feat: impl Soft Binding assertion definition * fix: remove `AssertionJson` impl for `SoftBinding` * fix: use usize for timespan * docs: clarify `alg_params` field string type * style: move soft binding pad fields to the bottom of struct * fix: soft binding region field optional and add unit + integration tests * fix: clippy lints * fix: use u64 instead of usize for soft binding time range * fix: hide and skip serializing deprecated soft binding fields and expose accessor * test: ignore deprecated url field in soft binding serialization test * docs: document deprecated methods and remove assertion creation version * refactor: move SoftBinding::pad/pad2 fields as methods and remove Map suffix from related structs * fix: `SoftBinding::alg_params`->`SoftBinding::alg-params` w/ serde --------- Co-authored-by: Eric Scouten <scouten@adobe.com> Co-authored-by: Gavin Peacock <gpeacock@adobe.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Implements the Soft Binding assertion definition. It exposes all public fields so it's clear in the docs how to deserialize into it and it provides no functions since everything is already accessible by field. Getters/setters can be added on if wanted, but there is already a lot of variation in the implementation of assertions.
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.