Support validating remote and external manifest stores #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for more BMFF container types Handle bad FourCC names Add bad signer unit test
…ternal_manifest * 'main' of https://github.com/contentauth/c2pa-rs: Fix for `sign_claim` masking error (#96) # Conflicts: # sdk/src/cose_sign.rs
Bug fixes Slight speed up
Auto cleanup temp content
…ternal_manifest * 'main' of https://github.com/contentauth/c2pa-rs: (IGNORE) Format `use` statements consistently (#99) (IGNORE) Clean up changelog formatting Prepare 0.11.3 release Remove inadvertent 1.0.0 release from changelog (#97) Prepare 1.0.0 release Treat 'meta' box as standard container (#95) # Conflicts: # sdk/src/asset_handlers/c2pa_io.rs # sdk/src/claim.rs # sdk/src/store.rs
Put remote manifest behind xmp_write feature Split external manifest into two functions
…ternal_manifest * 'main' of https://github.com/contentauth/c2pa-rs: (IGNORE) Proofreading in README file
…ternal_manifest * 'main' of https://github.com/contentauth/c2pa-rs: Fix box order for BMFF (#104) Added support for external manifests (#101)
…ternal_manifest * 'main' of https://github.com/contentauth/c2pa-rs: (IGNORE) Update makefile test to use nightly fmt and add fmt script (#103)
…ternal_manifest * 'main' of https://github.com/contentauth/c2pa-rs: Fix build error when xmp_write is not defined (#105)
Add support for embedding manifest and external reference into same file Remove obsolete XMP usages Code cleanup
gpeacock
changed the title
gpeacock
requested changes
Aug 11, 2022
Codecov Report
@@ Coverage Diff @@
## main #108 +/- ##
==========================================
- Coverage 77.23% 76.82% -0.42%
==========================================
Files 66 66
Lines 14084 14108 +24
==========================================
- Hits 10878 10838 -40
- Misses 3206 3270 +64
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gpeacock
approved these changes
Aug 12, 2022
scouten-adobe
added a commit
that referenced
this pull request
Aug 16, 2022
scouten-adobe
added a commit
that referenced
this pull request
Aug 16, 2022
mauricefisher64
added a commit
that referenced
this pull request
Aug 18, 2022
…b_test * 'main' of https://github.com/contentauth/c2pa-rs: Prepare 0.12.0 release Update C2PA manifest store mime type (#112) (IGNORE) (MINOR) PR #108 contained significant changes; bump version (#111) Updates Manifest API to support remote and external manifests (#107)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
The PR adds the ability to validate external .c2pa files and fetching and validating remote manifest stores. Includes
small amount of code cleanup.
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.