Fix box order for BMFF #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #104 +/- ##
==========================================
+ Coverage 75.82% 77.21% +1.39%
==========================================
Files 66 66
Lines 14067 14081 +14
==========================================
+ Hits 10666 10873 +207
+ Misses 3401 3208 -193
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
scouten-adobe
approved these changes
Aug 9, 2022
…x_BMFF_box_order * 'main' of https://github.com/contentauth/c2pa-rs: Added support for external manifests (#101) (IGNORE) Proofreading in README file (IGNORE) Format `use` statements consistently (#99) (IGNORE) Clean up changelog formatting Prepare 0.11.3 release Remove inadvertent 1.0.0 release from changelog (#97) Prepare 1.0.0 release Treat 'meta' box as standard container (#95) Fix for `sign_claim` masking error (#96)
mauricefisher64
added a commit
that referenced
this pull request
Aug 10, 2022
…ternal_manifest * 'main' of https://github.com/contentauth/c2pa-rs: Fix box order for BMFF (#104) Added support for external manifests (#101)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
C2PA box should be after ftyp box. Fix case where that could fail.
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.