Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/system: debug file leaks #23100

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test/system: debug file leaks #23100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contrib/cirrus/runner.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,8 +424,8 @@ dotest() {
# FIXME: https://github.com/containers/podman/issues/22642
# Cannot delete this due cleanup errors, as the VM is basically
# done after this anyway let's not block on this for now.
# rm -rf $TMPDIR
# unset TMPDIR
rm -rf $TMPDIR
unset TMPDIR
}

_run_machine-linux() {
Expand Down
2 changes: 2 additions & 0 deletions test/system/helpers.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,8 @@ function defer-assertion-failures() {
# Basic teardown: remove all pods and containers
function basic_teardown() {
echo "# [teardown]" >&2
# Debug for https://github.com/containers/podman/issues/22642
ls -l $TMPDIR >&3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure this works; ISTR that bats requires a # prefix in addition to fd3. But am not sure.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it worked locally but I guess the tty format is different from the CI "tap" format

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running with --tap also shows me the files so I assume it should work


immediate-assertion-failures
# Unlike normal tests teardown will not exit on first command failure
Expand Down