-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/system: debug file leaks #23100
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -204,6 +204,8 @@ function defer-assertion-failures() { | |||
# Basic teardown: remove all pods and containers | |||
function basic_teardown() { | |||
echo "# [teardown]" >&2 | |||
# Debug for https://github.com/containers/podman/issues/22642 | |||
ls -l $TMPDIR >&3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure this works; ISTR that bats requires a #
prefix in addition to fd3. But am not sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it worked locally but I guess the tty format is different from the CI "tap" format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running with --tap also shows me the files so I assume it should work
These leak in the file I checked. There is also intermediate-mountpoint-0.0 leaked bu this is expected #23032, I might want to look at a better way there |
A friendly reminder that this PR had no activity for 30 days. |
Does this PR introduce a user-facing change?