Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/system: debug file leaks #23100

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Jun 25, 2024

Does this PR introduce a user-facing change?


Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2024
Copy link
Contributor

openshift-ci bot commented Jun 25, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Jun 25, 2024
Copy link
Contributor

openshift-ci bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2024
@@ -204,6 +204,8 @@ function defer-assertion-failures() {
# Basic teardown: remove all pods and containers
function basic_teardown() {
echo "# [teardown]" >&2
# Debug for https://github.com/containers/podman/issues/22642
ls -l $TMPDIR >&3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure this works; ISTR that bats requires a # prefix in addition to fd3. But am not sure.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it worked locally but I guess the tty format is different from the CI "tap" format

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running with --tap also shows me the files so I assume it should work

@edsantiago
Copy link
Member

smoking gun in f39 root

@Luap99
Copy link
Member Author

Luap99 commented Jun 25, 2024

- podman build --authfile bogus
- podman image scp transfer

These leak in the file I checked. There is also intermediate-mountpoint-0.0 leaked bu this is expected #23032, I might want to look at a better way there

Copy link

A friendly reminder that this PR had no activity for 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. stale-pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants