Skip to content

Conversation

@mtrmac
Copy link
Contributor

@mtrmac mtrmac commented Feb 8, 2019

WIP, do not merge: Right now only to have a fallback implementation and to get it through CI.

The c/image branch is unmerged upstream.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 8, 2019
@mtrmac mtrmac force-pushed the multiple-manifests branch 2 times, most recently from a72abfc to 321f0cd Compare February 11, 2019 21:12
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac mtrmac force-pushed the multiple-manifests branch from 321f0cd to a6707e4 Compare February 13, 2019 21:24
@mtrmac mtrmac changed the title DO NOT MERGE: Vendor in latest c/storage and WIP c/image Vendor in latest c/storage and WIP c/image Feb 13, 2019
@mtrmac mtrmac changed the title Vendor in latest c/storage and WIP c/image Vendor in latest c/storage and c/image Feb 13, 2019
@mtrmac
Copy link
Contributor Author

mtrmac commented Feb 14, 2019

/retest

@mheon
Copy link
Member

mheon commented Feb 14, 2019

/approve
LGTM pending green tests

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, mtrmac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2019
@rhatdan
Copy link
Member

rhatdan commented Feb 14, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2019
@openshift-merge-robot openshift-merge-robot merged commit 1b352ff into containers:master Feb 14, 2019
@mtrmac mtrmac deleted the multiple-manifests branch February 14, 2019 21:17
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants