Skip to content

WIP: update containers/storage rw locks #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vrothberg wants to merge 1 commit into from
Closed

WIP: update containers/storage rw locks #2254

vrothberg wants to merge 1 commit into from

Conversation

@vrothberg
Copy link
Member

@vrothberg vrothberg commented Feb 1, 2019

Please, do not merge.

Signed-off-by: Valentin Rothberg rothberg@redhat.com

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 1, 2019
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2019
@rh-atomic-bot
Copy link
Collaborator

rh-atomic-bot commented Feb 1, 2019

☔ The latest upstream changes (presumably #2255) made this pull request unmergeable. Please resolve the merge conflicts.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 1, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2019
@vrothberg vrothberg mentioned this pull request Feb 4, 2019
Merged
@rh-atomic-bot
Copy link
Collaborator

rh-atomic-bot commented Feb 8, 2019

☔ The latest upstream changes (presumably #2274) made this pull request unmergeable. Please resolve the merge conflicts.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2019
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L labels Feb 11, 2019
@vrothberg
WIP - test reader-writer locks from containers/storage
a944e18 
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
@rh-atomic-bot
Copy link
Collaborator

rh-atomic-bot commented Feb 14, 2019

☔ The latest upstream changes (presumably #2298) made this pull request unmergeable. Please resolve the merge conflicts.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 16, 2019
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 16, 2019

@vrothberg: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrothberg
Copy link
Member Author

vrothberg commented Feb 21, 2019

Closing as another PR took care of it.

@vrothberg vrothberg closed this Feb 21, 2019
@vrothberg vrothberg deleted the storage-rw-locks branch February 21, 2019 12:40
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@TomSweeneyRedHat TomSweeneyRedHat Awaiting requested review from TomSweeneyRedHat

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vrothberg @openshift-ci-robot @rh-atomic-bot