Remove orphaned source files which are never used #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove vmm_config/console.rs file whis is never used (there is no corresponding `mod console`) and device_manager/mmio.rs which has been split into 2 versions: device_manager/kvm/mmio.rs and device_manager/hvf/mmio.rs Signed-off-by: Matej Hrica <mhrica@redhat.com>
mtjhrc
requested review from
jakecorrenti,
MatiasVara,
slp and
tylerfanelli
as code owners
tylerfanelli
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found 2 source code files which are never compiled, so we should remove them.
I found out about the
mmio.rsfile when working on #335 and realized I'm editing a file that isn't being compiled 😅I looked for other files, and found one other file, but I haven't looked too much if there are more. I don't know of a tool to automatically determine this fully automatically.
To search for orphaned modules the
cargo-modulespackage (specifically the commandcargo modules orphans) can be used. Because we have multiple target/feature combinations and even conditions like#[cfg(not(feature = "tee"))], this currently requires manually changing the target/features and comparing output to determine if something is orphan. So if we wanted to integrate it into CI, it would require more post processing (and possibly a PR to the tool to give more machine readable output).