Devices: clean up interrupt sending code #335
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtjhrc
force-pushed
the
device-refactor
branch
4 times, most recently
from
6d84bbb to
b10d57b
Compare
Add DeviceState::is_activated and use it in VirtioDevice::is_activated implementations. Signed-off-by: Matej Hrica <mhrica@redhat.com>
Signed-off-by: Matej Hrica <mhrica@redhat.com>
Create an abstraction InterruptTransport which sits at the MmioTransport layer. This holds all the necessary fields to send an interrupt. The InterruptTransport is passed to a VirtioDevice as a parameter for the activate() method call and is saved inside DeviceState::Active. Make IrqChip now passed into the MmioTransport::new. Because it is now always required, this removes the need to check if it is set before sending an interrupt. Previously we had around 15 copied implementations of signal_used_queue in the project. For every implementation/place (worker threads, etc) where signal_used_queue was necessary, one had to also pass around 4 variables. Signed-off-by: Matej Hrica <mhrica@redhat.com>
Introduce the method VirtioDevice::device_name(). Use this method in order to log with a custom target at the mmio transport layer, which contains the name as a suffix. This makes sure to log all signal_used_queue() calls issued by devices. Interrupt requests by a specific device can be filtered using the suffix. E.g. when debugging the GPU device you can do: RUST_LOG=devices::virtio::mmio[gpu]=trace,warn This will enable logging the interrupts only for the GPU device, but `warn!` logs will still be enabled globally, even for "devices::virtio::mmio". You can also still specify "devices::virtio::mmio=trace", which will log fo all devices. Signed-off-by: Matej Hrica <mhrica@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to remove some of the duplicate code we have in regards to sending interrupts.
We had around 15 copies of:
But also for each such a copy of the interrupt sending code, we had to pass around 4 variables
(interrupt_status, irq_line, intc, interrupt_evt)to each worker thread, which is quite silly.This simplifies the handling, by creating a struct
InterruptTransportwhich holds the fields and has asignal_used_queuemethod. TheInterruptTransportis managed by theMmioTransportpassing it to the device upon activation.