Bugfix/copy dir recursive destination check #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default value for new folders is 0777. This can be changed by calling chmod().
| protected function copyDir($src, $dst) | ||
| { | ||
| $dir = @opendir($src); | ||
| if (false === $dir) { | ||
| throw new TaskException($this, "Cannot open source directory '" . $src . "'"); | ||
| } | ||
| @mkdir($dst); | ||
| @mkdir($dst, $this->chmod); |
There was a problem hiding this comment.
this should be removed. I think the next lines do the same job
There was a problem hiding this comment.
Why? It will set the default permission there as well.
There was a problem hiding this comment.
This line was the cause of the error in #125 ...
Please see #126 (comment)
burzum
added a commit
that referenced
this pull request
Mar 15, 2015
…ion-check Bugfix/copy dir recursive destination check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should finish #126