Bugfix/CopyDir recursive destination check

[boedah]

Fixes #125 (see there for explanation).

Also added a test to check that files are overwritten.

[burzum]

Isn't 777 a little too much? I think 775 or 755 would be better.

Or check the parent folders permission and inherit them?

[boedah]

I did not want to change existing behavior, and 0777 is the default (http://php.net/manual/de/function.mkdir.php).

[burzum]

It's not like that standard php is secure at all. I think especially in the case of dealing with assets that are usually going into a public webroot it is critical to not set them to 777. This will make it very easy to add malicious files and code into files.

I would propose to set the default to 755 and give the user the option to change it:

->permissions(777)
->run();

[DavertMik]

permissions option is not very descriptive, could you propose something better?
I agree to provide better option for that, and maybe 755 is a good idea for making it standard.

[burzum]

dirPermissions(), folderPermissions()? chmod()?

[burzum]

I've added the permission feature in #145 :) @DavertMik let me know if you agree to the method name and I'll merge it ASAP.

[boedah]

Wow, to much updates in the last 24 hours...

This PR was solely about the recursive bug in #125 ( @DavertMik : can you comment on my question there as to why the CopyDir task is even needed)?

I did not want to break compatibility with existing code.

The whole permissions thing is another one (from my point of view) and should be an own PR (so it is clearly visible).

If you look at Symfonys Filesystem mkdir, the default mode is also 0777, and this method is used without a chmod argument in all copy(), mirror(), etc. methods. Those methods are in turn are used by Robos FilesystemStack.

So if you really want to clean up the permissions thing, you had to make PRs to Symfony for providing the mode or implement those functions in Robo directly (which seems not good, but the CopyDir task already does it, see above).

EDIT:
Just saw on http://php.net/manual/en/function.mkdir.php:

The mode is also modified by the current umask, which you can change using umask().

So the permissions should be alright, just did a quick test:

$ umask
0022
$ php -r 'mkdir("test1/test2", 0770, true);' && ls -la test1
drwxr-x---  2 pgasser pgasser 4096 Mar 13 10:10 test2

So maybe just merge this and decide on the permission cleanup in a new PR?
;)