-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.2 support #1135
Comments
Has already been fixed in #1131 unfortunately you have to build it yourself locally.
Should do it. |
Thank you for you reply. Yes, I saw the fix in the 4.x branch, but I think the Robo-3.x branch also should support PHP 8.2, because it is widely used and if the fix is easy like that. The README.md should be clear about that which branches accept PHP-8.2 related merge requests. I have several (~18) reusable Robo-3.x tasks, and I already make them compatible with PHP 8.2. (I noticed this issue during the update). I might be wrong, but with the current situation a Drupal-9.x project which uses Robo-3.x can't upgrade to PHP 8.2. (I know that there is Drupal-10, but still) |
I'll accept PRs that backport PHP 8.2 support to the 3.x branch. Note that although test coverage of the core Robo classes is very good, there are a lot of standard Robo tasks that have little to no coverage. This means that things like "supports PHP 8.2" PRs often have to happen iteratively, because it's easy to miss needed changes in uncovered classes. PRs with more tests would be particularly welcome. |
[MAILPOET-4900] When a new robo version with a fix for 'self' in callables is released, this patch can be removed. Check here: consolidation/robo#1135
[MAILPOET-4900] When a new robo version with a fix for 'self' in callables is released, this patch can be removed. Check here: consolidation/robo#1135
[MAILPOET-4900] When a new robo version with a fix for 'self' in callables is released, this patch can be removed. Check here: consolidation/robo#1135
According to the README.md non of the 3.x or 4.x branches support PHP 8.2,
but I think sooner or later PHP 8.2 should be supported, at least by the 4.x branch.
consolidation/robo:3.0.11 with PHP 8.2 the Exec task throws the following deprecation message:
There might be other problems as well.
The text was updated successfully, but these errors were encountered: