Issue #1135 - PHP 8.2 - Fix Use of "self" in callables is deprecated (#…

…1136)
consolidation · Dec 29, 2022 · a1f49b1 · a1f49b1
1 parent e1cc641
commit a1f49b1
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/src/Common/CommandArguments.php b/src/Common/CommandArguments.php
@@ -40,7 +40,7 @@ public function args($args)
         if (!is_array($args)) {
             $args = $func_args;
         }
-        $this->arguments .= ' ' . implode(' ', array_map('static::escape', $args));
+        $this->arguments .= ' ' . implode(' ', array_map([static::class, 'escape'], $args));
         return $this;
     }
 

diff --git a/src/Task/Base/Exec.php b/src/Task/Base/Exec.php
@@ -63,7 +63,7 @@ private function setupStopRunningJobs()
             return;
         }
 
-        $stopRunningJobs = Closure::fromCallable(['self', 'stopRunningJobs']);
+        $stopRunningJobs = Closure::fromCallable(self::class.'::stopRunningJobs');
 
         if (function_exists('pcntl_signal')) {
             pcntl_signal(SIGTERM, $stopRunningJobs);

diff --git a/tests/phpunit/Task/ExecTest.php b/tests/phpunit/Task/ExecTest.php
@@ -0,0 +1,19 @@
+<?php
+
+namespace phpunit\Task;
+
+use PHPUnit\Framework\TestCase;
+
+class ExecTest extends TestCase
+{
+
+    // tests
+    public function testBasicCommand()
+    {
+        $this->assertSame(
+            'ls',
+            (new \Robo\Task\Base\Exec('ls'))
+                ->getCommand()
+        );
+    }
+}