-
Notifications
You must be signed in to change notification settings - Fork 46
Fix cometbft precomit signatures comit sha #1466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Parent:
feat(node): validator cert
cryptoAtwill
merged 19 commits into
valiator-cert
from
fix-cometbft-precomit-signatures-comitSha
Oct 24, 2025
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
a5bca4b
feat: add commit SHA handling for contract deployment
phutchins c9f95e8
feat: enhance deployment error logging and add chainId to wizard conf…
phutchins a2b558d
feat: add health check script for validator management
phutchins 1b3496e
add validator cert
c9cf814
unit tests
c2ea93c
prettier
5195e99
more comments
c3d70b5
feat: integrate Anvil with IPC keystore for local development
phutchins 32f3487
add validator cert
0ce8045
unit tests
39ca9f1
prettier
db88873
more comments
4ee7f83
feat: add SSH tunnel setup script for remote validator access
phutchins aa6360e
add validator cert
1b35f9d
unit tests
cf4b510
prettier
f5ae730
more comments
ca2fa3e
fix conflicts
8135da2
Merge branch 'fix-cometbft-precomit-signatures-comitSha' of protocol-…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing Validation Case for
chainIdThe
chainIdfield was added to therequiredFieldsarray and form validation, but no corresponding validation case was added to thevalidateFieldfunction in the wizard store. When the validation runs,wizardStore.validateField('chainId', value)will fall through the switch statement and returnnull(no error), even if the chainId is missing or invalid. This means the chainId field can never show validation errors despite being marked as required and having error display binding in the template.