-
Notifications
You must be signed in to change notification settings - Fork 46
feat(node): validator cert #1465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cryptoAtwill
wants to merge
13
commits into
cometbft-precommit-signatures
Choose a base branch
from
valiator-cert
base: cometbft-precommit-signatures
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,198
−682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
| .await?; | ||
|
|
||
| next_height += self.metadata.period as u64; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the previous PR by introducing a bitmap to count which validator has pre-commit vote signature included.
This excludes:
Then contract will validate the cert onchain.
The point of this PR is to reduce gas usage for cometbft light client verification.
Note
Introduce bitmap-backed validator certificates for CometBFT quorum, adjust checkpoint/app-hash handling, and wire through node, CLI, and provider with new APIs and validations.
ValidatorCertificate { bitmap, signatures }; quorum verification iterates via bitmap.submitBottomUpCheckpointnow accepts(LightHeader, ValidatorCertificate, CanonicalVote)and treats app hash as height-1; addlastCommitmentHeight, rename internal tracking;recordAppHashBreakdownenforces sequencing and only records non-empty batches; exposederiveAppHash/validateAppHashas public.activeValidatorsLimit <= uint8::MAX; addTooManyValidators; changeInvalidCheckpointEpochto include(expected, actual).SubnetCheckpointtests.ValidatorCertificateABI type and bitmap construction;submit_signed_headernow sends certificate; newget_last_app_commitment_heightand app-hash breakdown submission uses Fendermint state root.--fendermint-rpc-url; integratefendermint_rpc; defaultmax_parallelismlowered.state_rootinStateParams; keep full state history for light client validation.Vec<u8>when human-readable.Written by Cursor Bugbot for commit 92dfd25. This will update automatically on new commits. Configure here.