Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest OTEL and semconv #128

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

pkwarren
Copy link
Contributor

Update to the latest version of the OTEL libraries. Migrate from semconv 1.12.0 to 1.21.0 (matching upstream opentelemetry-go change). Upgrade build dependencies.

Update to the latest version of the OTEL libraries. Migrate from semconv
1.12.0 to 1.21.0 (matching upstream opentelemetry-go change). Upgrade
build dependencies.
@@ -26,7 +26,7 @@ import (
"go.opentelemetry.io/otel/codes"
"go.opentelemetry.io/otel/metric"
"go.opentelemetry.io/otel/propagation"
semconv "go.opentelemetry.io/otel/semconv/v1.20.0"
semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -26,7 +26,7 @@ import (
)

const (
version = "0.0.1-dev"
version = "0.6.0-dev"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this is merged, would it be possible to do a release of 0.6.0?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

@@ -26,7 +26,7 @@ import (
)

const (
version = "0.0.1-dev"
version = "0.6.0-dev"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

@akshayjshah akshayjshah merged commit dd40403 into connectrpc:main Aug 29, 2023
4 checks passed
@pkwarren pkwarren deleted the pkw/upgrade-otel branch August 29, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants