Fix repeating group contains all preceding groups tags issue #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 18, 2013 21:02
In Message.SetGroup the grp variable was not being managed correctly for repeating groups. We ran into the issue while parsing FIX 4.4 Confirmation (AK).
For scenarios where QuickFixN is used as a parser in appications where the spec XML file(s) are deployed as embedded assembly resource(s).
|
The stream ctor was already added as part of #178. |
This was referenced May 15, 2013
Closed
|
The repeating group resolution will be tracked via #162. Thanks for your submission. It just needs a test. (In the future, please try to keep submissions to one feature/fix per pull request, and try to include tests adequate to verify a fix, or at least enough information so that someone else can write a test.) |
gbirchmeier
added a commit
that referenced
this pull request
May 15, 2013
hlibman-connamara
pushed a commit
to hlibman-connamara/quickfixn
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Message.SetGroup the grp variable was not being managed correctly for
repeating groups. We ran into the issue while parsing FIX 4.4
Confirmation (AK).
Also, added ctor to DataDictionary to ease scenarios where the spec XML file(s) are embedded as assembly resources. We do this in applications where QuickFixN is used as a parser only.