Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group parsing problem #176

Closed
TomasVetrovsky opened this issue Mar 19, 2013 · 5 comments
Closed

Group parsing problem #176

TomasVetrovsky opened this issue Mar 19, 2013 · 5 comments

Comments

@TomasVetrovsky
Copy link

Group gets corrupted when parsing message from string and MessageFactory is not set or MessageFactory fails to create typed Group. Parsing fails on the second instance of the group.

Grp must be reset to null when the last instance of group was added to fieldMap.

Message.SetGroup method:
...
// Create a new group!
if (msgFactory != null)
grp = msgFactory.Create(Message.ExtractBeginString(msgstr), Message.GetMsgType(msgstr), grpNoFld.Tag);

//If above failed (shouldn't ever happen), just use a generic Group.

//********** grp already contains first instance of group.
if (grp == null)
grp = new Group(grpNoFld.Tag, grpEntryDelimiterTag, order);

@gbirchmeier
Copy link
Member

I need more context to know that this is an engine problem and not a problem with your application.

  • What is the message being parsed?
  • Is that message coming from a counterparty session or are you creating it?
  • Are you sure your data dictionary is correct?
  • What do you mean by "Grp must be reset to null..."?

@TomasVetrovsky
Copy link
Author

Correction is under commit TomasVetrovsky@7d775ce

@TomasVetrovsky
Copy link
Author

We do not use message factory at all. We have different counterparties who use diferent dataDictionaries (different custom fields). If we use MessageFactory we would need different binaries for each counterparty. You can see the problem in the commit.

@gbirchmeier
Copy link
Member

I think same as #179 and #162

@gbirchmeier
Copy link
Member

Same as #179.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants