-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group parsing problem #176
Comments
I need more context to know that this is an engine problem and not a problem with your application.
|
Correction is under commit TomasVetrovsky@7d775ce |
We do not use message factory at all. We have different counterparties who use diferent dataDictionaries (different custom fields). If we use MessageFactory we would need different binaries for each counterparty. You can see the problem in the commit. |
Same as #179. |
Group gets corrupted when parsing message from string and MessageFactory is not set or MessageFactory fails to create typed Group. Parsing fails on the second instance of the group.
Grp must be reset to null when the last instance of group was added to fieldMap.
Message.SetGroup method:
...
// Create a new group!
if (msgFactory != null)
grp = msgFactory.Create(Message.ExtractBeginString(msgstr), Message.GetMsgType(msgstr), grpNoFld.Tag);
//If above failed (shouldn't ever happen), just use a generic Group.
//********** grp already contains first instance of group.
if (grp == null)
grp = new Group(grpNoFld.Tag, grpEntryDelimiterTag, order);
The text was updated successfully, but these errors were encountered: