ON HOLD: add no-floating-promises eslint rule
#1498
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This PR will be periodically updated with
mainafter we've had a chance to clean up some of the offending areas of the codebase so we don't try and merge a huge changeset in from this branch. Oncegulp lintis green in this branch, the only changes going in should be fromeslint.config.mjs.This rule will flag any calls returning a
Promisethat aren'tawaited.https://typescript-eslint.io/rules/no-floating-promises/
This currently shows a lot of failures (100+) during

gulp lint:...but we can create some PRs based on this branch to slowly chip away at the different offenders either through adding the
voidoperator,awaiting the promise, or adding the following above an offending line: