Skip to content

Conversation

@shouples
Copy link
Contributor

@shouples shouples commented Apr 16, 2025

Important

This PR will be periodically updated with main after we've had a chance to clean up some of the offending areas of the codebase so we don't try and merge a huge changeset in from this branch. Once gulp lint is green in this branch, the only changes going in should be from eslint.config.mjs.

This rule will flag any calls returning a Promise that aren't awaited.

https://typescript-eslint.io/rules/no-floating-promises/


This currently shows a lot of failures (100+) during gulp lint:
image

...but we can create some PRs based on this branch to slowly chip away at the different offenders either through adding the void operator, awaiting the promise, or adding the following above an offending line:

// eslint-disable-next-line @typescript-eslint/no-floating-promises

@shouples shouples added the on hold Blocked until additional functionality is available or more discussions have happened. label Apr 16, 2025
@cprovencher cprovencher added rebase and removed rebase labels May 16, 2025
@shouples shouples added cleanup General refactoring and/or minor adjustments needed that shouldn't impact overall functionality optimization Make something more efficient labels Oct 14, 2025
@shouples
Copy link
Contributor Author

Closing since it's set to warn on main, so we can chip away at the remaining <50 warnings when time permits.

@shouples shouples closed this Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup General refactoring and/or minor adjustments needed that shouldn't impact overall functionality on hold Blocked until additional functionality is available or more discussions have happened. optimization Make something more efficient

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants