ON HOLD: enable require-await eslint rule
#1865
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shouples
added
the
on hold
Analysis Details0 Issues
Coverage and Duplications
Project ID: vscode |
shouples
changed the title
require-await eslint rulerequire-await eslint rule
shouples
added
cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This PR will be periodically updated with
mainafter we've had a chance to clean up some of the offending areas of the codebase so we don't try and merge a huge changeset in from this branch. Oncegulp lintis green in this branch, the only changes going in should be fromeslint.config.mjs.Similar to #1498, but for catching any functions/methods that don't need to be
async.https://eslint.org/docs/latest/rules/require-await