Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace HashableDict with frozendict.deepfreeze #27151

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

AdrianFreundQC
Copy link

@AdrianFreundQC AdrianFreundQC commented Aug 1, 2024

Supersedes #27150.

HashableDict has been removed from conda_build in 24.7 and has been deprecated since 24.5.
This caused all PR CI builds to fail.
The deprecation message recommends using frozendict.deepfreeze instead.

I don't have permission to add the maintainance tag to this PR, so linter complains about changing non-recipe files.

Closes conda-forge/conda-forge-ci-setup-feedstock#332

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

Copy link

github-actions bot commented Aug 1, 2024

Hi! Thanks for your contribution to conda-forge.
We appreciate your effort in improving our project.
However, it looks like some changes were made outside the recipes directory.
To ensure everything runs smoothly, please make sure that recipes are only added to the recipes folder and no other files are changed.
Please make sure that any changes are reverted before you submit your pull request for review.

If these changes are intentional (and you aren't submitting a recipe), please attach a maintenance label to the PR.
Thanks!

Copy link

github-actions bot commented Aug 1, 2024

Hi! Thanks for your contribution to conda-forge.
We appreciate your effort in improving our project.
However, it looks like some changes were made outside the recipes directory.
To ensure everything runs smoothly, please make sure that recipes are only added to the recipes folder and no other files are changed.
Please make sure that any changes are reverted before you submit your pull request for review.

If these changes are intentional (and you aren't submitting a recipe), please attach a maintenance label to the PR.
Thanks!

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/kubeseal/meta.yaml) and found some lint.

Here's what I've got...

For recipes/kubeseal/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: 0xbe7a. Please ask them to comment on this PR if they are.

Copy link

github-actions bot commented Aug 1, 2024

Hi! Thanks for your contribution to conda-forge.
We appreciate your effort in improving our project.
However, it looks like some changes were made outside the recipes directory.
To ensure everything runs smoothly, please make sure that recipes are only added to the recipes folder and no other files are changed.
Please make sure that any changes are reverted before you submit your pull request for review.

If these changes are intentional (and you aren't submitting a recipe), please attach a maintenance label to the PR.
Thanks!

1 similar comment
Copy link

github-actions bot commented Aug 1, 2024

Hi! Thanks for your contribution to conda-forge.
We appreciate your effort in improving our project.
However, it looks like some changes were made outside the recipes directory.
To ensure everything runs smoothly, please make sure that recipes are only added to the recipes folder and no other files are changed.
Please make sure that any changes are reverted before you submit your pull request for review.

If these changes are intentional (and you aren't submitting a recipe), please attach a maintenance label to the PR.
Thanks!

HashableDict has been removed from conda_build in 24.7 and has been
deprecated since 24.5.
This removed the need to to pin conda_build to <24.7
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

Copy link

github-actions bot commented Aug 1, 2024

Hi! Thanks for your contribution to conda-forge.
We appreciate your effort in improving our project.
However, it looks like some changes were made outside the recipes directory.
To ensure everything runs smoothly, please make sure that recipes are only added to the recipes folder and no other files are changed.
Please make sure that any changes are reverted before you submit your pull request for review.

If these changes are intentional (and you aren't submitting a recipe), please attach a maintenance label to the PR.
Thanks!

@AdrianFreundQC
Copy link
Author

CI confirmed working. Removed the test recipe again.
I don't have permission to add the maintainance tag to this PR, so linter complains about changing non-recipe files.

Now ready for review @conda-forge/staged-recipes

@AdrianFreundQC AdrianFreundQC marked this pull request as ready for review August 1, 2024 13:27
Copy link

github-actions bot commented Aug 1, 2024

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@mediocretech mediocretech mentioned this pull request Aug 1, 2024
10 tasks
@tetov tetov mentioned this pull request Aug 1, 2024
9 tasks
@isuruf isuruf merged commit bb7f0e2 into conda-forge:main Aug 1, 2024
5 of 6 checks passed
@isuruf
Copy link
Member

isuruf commented Aug 1, 2024

Thanks

@AdrianFreundQC AdrianFreundQC deleted the remove-hashabledict-usage branch August 1, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

cannot import name 'HashableDict' from 'conda_build.utils'
3 participants